-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support resolvePackagePath
for dynamic backend plugins.
#1071
Support resolvePackagePath
for dynamic backend plugins.
#1071
Conversation
db682af
to
5e40d8e
Compare
The image is available at: |
backstage-showcase Tests on commit bbe8ba0 finished with errors. |
5e40d8e
to
082eb01
Compare
The image is available at: |
Anything to do about the sonarcloud issues? The code complexity one might be worth a 2nd look. |
082eb01
to
00e2225
Compare
The image is available at: |
00e2225
to
e99fb85
Compare
The image is available at: |
Signed-off-by: David Festal <dfestal@redhat.com>
e99fb85
to
83cbd56
Compare
Quality Gate passedIssues Measures |
The image is available at: |
/cherry-pick 1.1.x |
@schultzp2020: once the present PR merges, I will cherry-pick it on top of 1.1.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gashcrumb, schultzp2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@schultzp2020: new pull request created: #1076 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Yi Cai <yicai@redhat.com> added card styles to match pf5 Signed-off-by: Yi Cai <yicai@redhat.com> E2E: upload Playwright report and add view report link to PR (janus-idp#1068) * chore(ci): upload Playwright report and add view report link to PR * Update functions.sh chore(ci): fix link to Playwright report in GitHub comment chore(deps): bump jose (janus-idp#1058) Bumps [jose](https://github.com/panva/jose) from 4.15.4 to 4.15.5. - [Release notes](https://github.com/panva/jose/releases) - [Changelog](https://github.com/panva/jose/blob/v4.15.5/CHANGELOG.md) - [Commits](panva/jose@v4.15.4...v4.15.5) --- updated-dependencies: - dependency-name: jose dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump jose from 4.15.4 to 4.15.5 (janus-idp#1059) Bumps [jose](https://github.com/panva/jose) from 4.15.4 to 4.15.5. - [Release notes](https://github.com/panva/jose/releases) - [Changelog](https://github.com/panva/jose/blob/v4.15.5/CHANGELOG.md) - [Commits](panva/jose@v4.15.4...v4.15.5) --- updated-dependencies: - dependency-name: jose dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Support `resolvePackagePath` for dynamic backend plugins. (janus-idp#1071) Signed-off-by: David Festal <dfestal@redhat.com> Fix topology height Signed-off-by: Yi Cai <yicai@redhat.com>
Description
A big number of upstream backstage backend plugins usie the
resolvePackagePath
function provided by thebackstage-common
package.This function doesn't work with the plugins are converted to dynamic and loaded dynamically.
This PR customizes the default
CommonJSLoader
used by the upstreamDynamicPluginManager
when loading dynamic plugins, so that calls to theresolvePackagePath()
function in order to retrieve the plugin package folder can now succeed.Which issue(s) does this PR fix
No issue for now.
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer